Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Navigation buttons accessibility fixes #1050

Merged
merged 3 commits into from Nov 8, 2022

Conversation

scmmmh
Copy link
Contributor

@scmmmh scmmmh commented Nov 7, 2022

This PR fixes keyboard accessibility issues for the search button and the theme switcher button

@scmmmh scmmmh changed the title Nav button a11y fixes FIX: Navigation buttons accessibility fixes Nov 7, 2022
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks for noticing and making the improvement 👍

+1 to merge once tests pass

@scmmmh
Copy link
Contributor Author

scmmmh commented Nov 8, 2022

Happy to help. Hopefully I'll be able to provide a few more accessibility fixes in the near future, I just wanted to start with a relatively simple one.

1 similar comment
@scmmmh
Copy link
Contributor Author

scmmmh commented Nov 8, 2022

Happy to help. Hopefully I'll be able to provide a few more accessibility fixes in the near future, I just wanted to start with a relatively simple one.

@choldgraf choldgraf merged commit 06577f7 into pydata:main Nov 8, 2022
@12rambau 12rambau mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light/Dark switch not accessible to keyboard navigation
2 participants