New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme broken for gitlab links with more than subgroup #1039
Comments
We are very welcoming PR and your suggestions seems very sensible. I did coded the shortening function but I have very little knowledge about how gitlab build the url. If you want to edit it it's done here:
|
Sounds good, Thanks for your feedback! I opened a PR, please leave your suggestions and comments there :) |
Thanks for merging! Does it make sense to add this to the 0.12 or 0.11.1 release? |
anything merged to master will be included in the next release |
Ah got it, thx for clarifying! :) |
In #841 link shortening was introduced which is breaking a gitlab (and github) link into several pieces.
This being introduced has two major drawbacks:
https://gitlab.com/organisation/subgroup1/soubgroup2/repository/-/merge_requests/4
will be displayed asorganisation/subgroup1
instead oforganisation/…/4
ororganisation/subgroup1/soubgroup2/repository/4
.https://gitlab.com/organisation/repository/-/pipelines
becomesorganisation/repository
.To my understanding the feature should only apply to those fields mentioned in https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/__init__.py#L958 and should take subgroups into account.
If possible, a configuration entry to opt out would be helpful as a short term solution here as well.
Would you be welcoming a PR in this direction or am I misunderstanding something or don't see another ticket discussing this?
The text was updated successfully, but these errors were encountered: