Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parsing of custom root models #4884

Merged
merged 1 commit into from Dec 29, 2022

Conversation

gou177
Copy link

@gou177 gou177 commented Dec 29, 2022

Fixes #4883

@gou177
Copy link
Author

gou177 commented Dec 29, 2022

please review

@samuelcolvin
Copy link
Member

samuelcolvin commented Dec 29, 2022

Ok, but please avoid recalling obj.__fields__.keys(). ignore, this is wrong.

Please update.

@hramezani @PrettyWood @adriangb can you think of any reason why this should break v1.10.3?

@PrettyWood
Copy link
Member

Looks ok to me

@hramezani
Copy link
Member

LGTM 👍

@samuelcolvin samuelcolvin mentioned this pull request Dec 29, 2022
8 tasks
@samuelcolvin samuelcolvin changed the title fix: Parsing of custom root models (#4883) fix: Parsing of custom root models Dec 29, 2022
@samuelcolvin samuelcolvin merged commit a220f87 into pydantic:1.10.X-fixes Dec 29, 2022
@samuelcolvin
Copy link
Member

Thanks so much @gou177 🙇.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants