Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: replace URL types with a 3rd party library #4694

Closed
samuelcolvin opened this issue Oct 31, 2022 · 3 comments
Closed

V2: replace URL types with a 3rd party library #4694

samuelcolvin opened this issue Oct 31, 2022 · 3 comments
Assignees
Labels
bug V1 Bug related to Pydantic V1.X Change Suggested alteration to pydantic, not a new feature nor a bug

Comments

@samuelcolvin
Copy link
Member

As per #4470, the URL types - everything inheriting from AnyUrl are messed up, it may just be weird edge cases that don't work, but getting URLs to be validated correct is a really hard task and shouldn't be included in pydantic.

In V2, we should use a 3rd party library for URL parsing and validation, ideally in rust as part of pydantic-core.

@samuelcolvin samuelcolvin added bug V1 Bug related to Pydantic V1.X Change Suggested alteration to pydantic, not a new feature nor a bug labels Oct 31, 2022
@samuelcolvin
Copy link
Member Author

Also #1665 - remove user_required.

@commonism
Copy link
Contributor

I can recommend yarl.URL

@samuelcolvin
Copy link
Member Author

This is done, we're using the URL crate from rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V1 Bug related to Pydantic V1.X Change Suggested alteration to pydantic, not a new feature nor a bug
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants