Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #4224.
fix #4458, fix #4468. Replaces #4469 and #4461.
There are a number of problems with #4224:
/
, this could also be fixed by Fix existing percent encoding #4469+
, this was reported in AnyUrl percent encoding (#3061) introduced v1.10.0 breaks database connection string #4468 and could also be fixed by Fix existing percent encoding #4469rebuild
for all URL validation, lots of tests fail, fixing those tests involves significant changes and we're well into the "this is not really suitable for a patch release" territory.Therefore after some consideration and discussion with other pydantic maintainers (and with a heavy heart), I've decided the best approach is to remove percentage encoding from URL logic until V2.
Long term (e.g. in V2) I think we should use an external library (either in python or rust) to perform URL parsing and validation.