Add __hash__ operator to Color class #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
hramezani
reviewed
Aug 31, 2022
|
Thanks @Czaki for reporting the issue and preparing the fix 👍 I left a small suggestion. |
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
|
Thanks so much. I haven't had any other bugs reported on v1.10 yet, so I'll make a patch release for just this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add
__hash__method topydantic.color.Colorclass.Related issue number
fix #4454
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details.
You can skip this check if the change does not need a change file.)