Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type hints in BaseSettings.Config #4450

Merged
merged 2 commits into from Aug 30, 2022
Merged

fix type hints in BaseSettings.Config #4450

merged 2 commits into from Aug 30, 2022

Conversation

samuelcolvin
Copy link
Member

Change Summary

Add type hints to BaseSettings.Config to avoid mypy errors, also correct mypy version compatibility comment in the docs.

Related issue number

See #4223 (comment)

@samuelcolvin
Copy link
Member Author

I think this is ready, please review.

hramezani
hramezani approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@samuelcolvin samuelcolvin mentioned this pull request Aug 30, 2022
Closed
@samuelcolvin samuelcolvin merged commit b065908 into main Aug 30, 2022
@samuelcolvin samuelcolvin deleted the settings-config-hints branch August 30, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

@samuelcolvin samuelcolvin

@PrettyWood PrettyWood

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelcolvin @hramezani @PrettyWood