Warn and ignore __slots__ argument to create_model
#4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review. |
5 tasks
samuelcolvin
changed the title
__slots__ argument to create_model
|
Except the failing CI, LGTM 👍 |
|
I'll wait for @hot123s (author of #3946) and @PrettyWood to review, then I think we're ready for a final pre-release - |
PrettyWood
approved these changes
Aug 24, 2022
Comment on lines
+341
to
+343
| # With python 3.8, specifically 3.8.10, Literal "is" check sare very flakey | ||
| # can change on very subtle changes like use of types in other modules, | ||
| # hopefully this check avoids that issue. |
There was a problem hiding this comment.
I would love to know what is compiled behind the scene to understand how this edge case arrives. Such a weird bug
There was a problem hiding this comment.
I agree, so weird.
The line that caused the issue again was __slots__: Optional[Tuple[str, ...]] = None,, if I changed it to __slots__: 'Optional[Tuple[str, ...]]' = None, it went again. But I decided this was a safer fix.
|
okay, I want to get the (hopefully) last pre-release out, so I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while investigating error in litestar-org/litestar#401
Change Summary
In v1.9.2
__slots__could be passed tocreate_model, I'm not sure if it was honoured or ignored, but it didn't cause an error.In v1.10.0a2 however it caused a warning, and if that warning was ignored, an error creating the model.
This was happening here
Even more unusually, this only seemed to be an error if pydantic is compiled.
With this change a
RuntimeWarningis raised, and__slots__is then ignored.Related issue number
Caused by #3946 I think.