Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --no-implicit-optional #4426

Closed
samuelcolvin opened this issue Aug 23, 2022 · 1 comment
Closed

Use --no-implicit-optional #4426

samuelcolvin opened this issue Aug 23, 2022 · 1 comment
Labels
Change Suggested alteration to pydantic, not a new feature nor a bug
Milestone
Version 2 Issues

Comments

@samuelcolvin
Copy link
Member

See #4378.

This makes type checking PEP 484 compliant (as of 2018).
mypy will change its defaults soon.

See:
python/mypy#9091
python/mypy#13401
@samuelcolvin samuelcolvin added the Change Suggested alteration to pydantic, not a new feature nor a bug label Aug 23, 2022
@samuelcolvin samuelcolvin added this to the Version 2 milestone Aug 23, 2022
@adriangb
Copy link
Member

We now follow the --no-implicit-optional behavior in V2 (and type check our code against it as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Change Suggested alteration to pydantic, not a new feature nor a bug
Projects
None yet
Milestone
Version 2 Issues
Development

No branches or pull requests
2 participants
@adriangb @samuelcolvin