Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master to main #4405

Merged
merged 1 commit into from Aug 19, 2022
Merged

Rename master to main #4405

merged 1 commit into from Aug 19, 2022

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Aug 19, 2022

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@hramezani
Copy link
Member Author

Please review

@PrettyWood
Copy link
Member

I would wait for v1.10 to be out and rolling before making this change

@hramezani
Copy link
Member Author

hramezani commented Aug 19, 2022

@PrettyWood
Fine for me as well

@hramezani hramezani added the deferred deferred until future release or until something else gets done label Aug 19, 2022
@samuelcolvin
Copy link
Member

I should probably have waited, but I took the opportunity while we didn't have too many option PRs, probably a mistake.

Anyway, now I've changed it, better to merge this.

@samuelcolvin samuelcolvin merged commit abcf81e into pydantic:main Aug 19, 2022
@hramezani hramezani deleted the master_to_main branch August 19, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred deferred until future release or until something else gets done ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants