New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for re.Pattern
#4366
Conversation
9f1d3f4
to
66d9348
Compare
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked this as well but it seems we don't need it because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test for schema, just to be sure.
Also Please remember "fix #xxx" in the PR body, I won't always remember to update it.
please update.
The test for the schema is part of test_pattern
I didn't add |
Good point, sorry my mistake. |
please review |
thanks so much. |
Change Summary
Add support for
re.Pattern
Related issue number
ref #4360
This PR just address the
re.pattern
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)