Fix __post_init_post_parse__ is incorrectly passed keyword arguments when no __post_init__ is defined #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review |
PrettyWood
reviewed
Aug 9, 2022
…when no __post_init__ is defined
samuelcolvin
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
LGTM, @PrettyWood if you're happy please merge.
@hramezani please remember "fix" in the PR body so the issue get's closed, otherwise I'll forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
fix #4342
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)