New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix imports indirectly from pydantic typing #4358
Fix imports indirectly from pydantic typing #4358
Conversation
This will also close #4182 to keep consistency in |
Thanks, if this is closing issues, please put them in the PR body so they get auto-closed. Please update. |
please review |
Thanks @aminalaee for the patch 👍 There are some other
|
please update |
Thank you for the review @hramezani . I'd only checked the top imports, this should be ok now. please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aminalaee for the update 👍
Hi @aminalaee please update to add a change file. Otherwise LGTM. |
Sorry I'd forgotten to add that. please review again. |
Thanks so much. |
current pydantic 1.10.2 see pydantic/pydantic#4358 Fix imports indirectly from pydantic typing #4358
Change Summary
Some imports indirectly get
ForwardRef
and other types from.typing
instead oftyping
module. I came across this when I was working on something else.Closes #4182
Related issue number
None
Checklist
changes/<pull request or issue id>-<github username>.md
file added describing change(see changes/README.md for details)