Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs after migrating to organization #4348

Merged
merged 2 commits into from Aug 8, 2022

Conversation

yezz123
Copy link
Contributor

@yezz123 yezz123 commented Aug 8, 2022

Change Summary

After Migrating Pydantic from Samuel's account to a Pydantic Organization, it's better to change the URLs used in different files.

Related issue number

Checklist

  • Unit tests for the changes that exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you just add a change description saying "moved repo to pydantic/pydantic" or similar so the change is shown in the changelog.

@samuelcolvin
Copy link
Member

please update

@hramezani
Copy link
Member

@samuelcolvin seems your change in requirements.txt missed here

@samuelcolvin
Copy link
Member

@samuelcolvin seems your change in requirements.txt missed here

Ye, but that was unrelated, I just noticed it while looking through files, this is good.

@yezz123
Copy link
Contributor Author

yezz123 commented Aug 8, 2022

please update

Done @samuelcolvin 🕺🏻

@samuelcolvin samuelcolvin enabled auto-merge (squash) August 8, 2022 11:42
@samuelcolvin
Copy link
Member

Thanks so much @yezz123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants