different nested List deep clone beheviour between 1.8.2/1.9 and 1.9.1

[robinvd]

Checks

• I added a descriptive title to this issue
• I have searched (google, github) for similar issues and couldn't find anything
  • copy_on_model_validation config doesn't copy List field anymore in v1.9.0 #3641 the fix for this seems to be the origin. But that issue is a change from 1.8.2 -> 1.9, while this issue works fine on 1.8.2 and 1.9 so its a different issue than copy_on_model_validation config doesn't copy List field anymore in v1.9.0 #3641
• I have read and followed the docs and still think this is a bug
  • this could be intended behavior but would still be a breaking change and missing in the changelogs.

Sorry to sound so draconian, but every second saved replying to issues is time spend improving pydantic :-)

Ofc you must get a lot of issues as the maintainer of a popular package.

Bug

Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":

❯ python -c "import pydantic.utils; print(pydantic.utils.version_info())"
             pydantic version: 1.9.1
            pydantic compiled: True
                 install path: /home/robin/prog/work/linestagger/venv/lib/python3.8/site-packages/pydantic
               python version: 3.8.10 (default, Mar 15 2022, 12:22:08)  [GCC 9.4.0]
                     platform: Linux-5.13.0-44-generic-x86_64-with-glibc2.29
     optional deps. installed: ['typing-extensions']

repro:

from typing import List
from pydantic import BaseModel


class Item(BaseModel):
    names: List[str]


class Container(BaseModel):
    inner: List[Item]


item = Item(names=["a"])
cont = Container(inner=[item])

print(len(item.names), len(cont.inner[0].names))
cont.inner[0].names.append("b")
print(len(item.names), len(cont.inner[0].names))

1.8.2 and 1.9.0

1 1
2 2

1.9.1

1 1
1 2

[hramezani]

I think it got fixed on v1.9.2. Please reopen it if it's not fixed.

[robinvd]

fixed!