Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to upper function for strings and bytes #4165

Merged
merged 18 commits into from Aug 8, 2022
Merged

Add to upper function for strings and bytes #4165

merged 18 commits into from Aug 8, 2022

Conversation

satheler
Copy link
Contributor

@satheler satheler commented Jun 16, 2022 •
edited

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@satheler
Copy link
Contributor Author

please review

hramezani
hramezani reviewed Jul 11, 2022
View reviewed changes
tests/test_types.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Thanks @satheler for your patch 👍
In general, it LGTM. I just left some comments to improve the readability.

@hramezani
Copy link
Member

please update

@github-actions github-actions bot assigned satheler and unassigned samuelcolvin and PrettyWood Jul 11, 2022
@satheler
Copy link
Contributor Author

@hramezani thank you for your suggestions. I made the suggested changes.

@satheler satheler requested a review from hramezani July 16, 2022 17:28
hramezani
hramezani reviewed Jul 17, 2022
View reviewed changes
tests/test_types.py Outdated Show resolved Hide resolved
hramezani
hramezani reviewed Jul 17, 2022
View reviewed changes
tests/test_types.py Outdated Show resolved Hide resolved
@hramezani
Copy link
Member

Thanks @satheler for updating the patch, Please use pytest.mark.parametrize for other tests as well.

@hramezani
Copy link
Member

please review

@github-actions github-actions bot assigned samuelcolvin and unassigned satheler Jul 17, 2022
@hramezani
Copy link
Member

please update

@satheler
Copy link
Contributor Author

satheler commented Jul 23, 2022 •
edited

@hramezani I took advantage and already did the refactoring for lower and strip_whitespace tests.

@satheler satheler requested a review from hramezani July 23, 2022 23:16
@satheler
Copy link
Contributor Author

please review

@samuelcolvin samuelcolvin merged commit d90def3 into pydantic:master Aug 8, 2022
@samuelcolvin
Copy link
Member

thanks so much @satheler.

@satheler satheler mentioned this pull request Aug 20, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

@samuelcolvin samuelcolvin

@PrettyWood PrettyWood

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@satheler @hramezani @samuelcolvin @PrettyWood