Fix Json strategy serialization failure #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioSim
force-pushed
the
fix-nested-json-strategy
branch
from
5ce6912
to
f18f623
Compare
|
please review |
SergioSim
force-pushed
the
fix-nested-json-strategy
branch
from
f18f623
to
f669c91
Compare
SergioSim
force-pushed
the
fix-nested-json-strategy
branch
from
f669c91
to
571e0bb
Compare
hramezani
reviewed
Jul 19, 2022
|
Thanks @SergioSim for the patch 👍 Please update |
SergioSim
force-pushed
the
fix-nested-json-strategy
branch
from
571e0bb
to
31ab8be
Compare
Thanks for the review @hramezani 👍 Added the please review |
github-actions
bot
assigned hramezani, PrettyWood and samuelcolvin and unassigned SergioSim
hramezani
reviewed
Jul 20, 2022
|
Thanks @SergioSim for updating. Just a small improvement in the change file. Please update |
github-actions
bot
assigned SergioSim and unassigned hramezani, samuelcolvin and PrettyWood
When generating a pydantic model having nested Json fields with hypothesis, a JSON serialization exception was raised.
SergioSim
force-pushed
the
fix-nested-json-strategy
branch
from
6a5dd1e
to
1ec0a47
Compare
Thanks for your feedback @hramezani 👍 Updated the change file. Please review |
github-actions
bot
assigned hramezani, PrettyWood and samuelcolvin and unassigned SergioSim
hramezani
approved these changes
Jul 20, 2022
|
thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating pydantic models having nested
Jsonfields withhypothesis, a JSON serialization exception was raised.
Change Summary
Changed the
resolve_jsonfunction inpydantic/_hypothesis_plugin.pyto use the pydantic json serializer if the type passed to theJsonfield is a subclass ofpydantic.BaseModel.Related issue number
fix #4004
Checklist
Documentation reflects the changes where applicablechanges/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)