diff --git a/pydantic/fields.py b/pydantic/fields.py index ff7b962f7ba..9ac1203c85d 100644 --- a/pydantic/fields.py +++ b/pydantic/fields.py @@ -732,6 +732,10 @@ def prepare_discriminated_union_sub_fields(self) -> None: Note that this process can be aborted if a `ForwardRef` is encountered """ assert self.discriminator_key is not None + + if self.type_.__class__ is DeferredType: + return + assert self.sub_fields is not None sub_fields_mapping: Dict[str, 'ModelField'] = {} all_aliases: Set[str] = set() diff --git a/tests/test_discrimated_union.py b/tests/test_discrimated_union.py index 520301174f8..f308f841495 100644 --- a/tests/test_discrimated_union.py +++ b/tests/test_discrimated_union.py @@ -1,12 +1,13 @@ import re from enum import Enum -from typing import Union +from typing import Generic, TypeVar, Union import pytest from typing_extensions import Annotated, Literal from pydantic import BaseModel, Field, ValidationError from pydantic.errors import ConfigError +from pydantic.generics import GenericModel def test_discriminated_union_only_union(): @@ -361,3 +362,36 @@ class Model(BaseModel): n: int assert isinstance(Model(**{'pet': {'pet_type': 'dog', 'name': 'Milou'}, 'n': 5}).pet, Dog) + + +def test_generic(): + T = TypeVar('T') + + class Success(GenericModel, Generic[T]): + type: Literal['Success'] = 'Success' + + data: T + + class Failure(BaseModel): + type: Literal['Failure'] = 'Failure' + error_message: str + + class Container(GenericModel, Generic[T]): + result: Union[Success[T], Failure] = Field(discriminator='type') + + with pytest.raises(ValidationError, match="Discriminator 'type' is missing in value"): + Container[str].parse_obj({'result': {}}) + + with pytest.raises( + ValidationError, + match=re.escape("No match for discriminator 'type' and value 'Other' (allowed values: 'Success', 'Failure')"), + ): + Container[str].parse_obj({'result': {'type': 'Other'}}) + + with pytest.raises( + ValidationError, match=re.escape('Container[str]\nresult -> Success[str] -> data\n field required') + ): + Container[str].parse_obj({'result': {'type': 'Success'}}) + + # coercion is done properly + assert Container[str].parse_obj({'result': {'type': 'Success', 'data': 1}}).result.data == '1'