Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Types from Pydantic to Pydantic-extra-types #1

Closed
6 tasks done
yezz123 opened this issue Feb 6, 2023 · 5 comments
Closed
6 tasks done

Migrate Types from Pydantic to Pydantic-extra-types #1

yezz123 opened this issue Feb 6, 2023 · 5 comments
Assignees

Comments

@yezz123
Copy link
Collaborator

yezz123 commented Feb 6, 2023

I create This issue to initialize the work on Pydantic Extra types, as we discuss it here pydantic/pydantic#5012


TODO:

Add Types such as:

@yezz123 yezz123 self-assigned this Feb 6, 2023
@yezz123 yezz123 linked a pull request Feb 6, 2023 that will close this issue
@yezz123 yezz123 removed a link to a pull request Feb 7, 2023
@yezz123 yezz123 pinned this issue Feb 7, 2023
@Kludex
Copy link
Member

Kludex commented Jun 5, 2023

What are we missing here? All checks are done on the description. 👀

@yezz123
Copy link
Collaborator Author

yezz123 commented Jun 5, 2023

What are we missing here? All checks are done on the description. 👀

This one #12

@Kludex
Copy link
Member

Kludex commented Jun 5, 2023

but that was never included on pydantic, that's a new type, isn't it?

Like, the issue title here reflects a migration from pydantic to pydantic-extra-types.

@yezz123
Copy link
Collaborator Author

yezz123 commented Jun 5, 2023

Yes never been in Pydantic, but as I remember we need to include it in the first release I guess

@samuelcolvin
Copy link
Member

for the first release we don't need anything beyond what was in pydantic V1, but we do need to make sure all the types that are included are working correctly.

@yezz123 yezz123 unpinned this issue Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants