Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyMapping improvements #302

Closed
samuelcolvin opened this issue Oct 18, 2022 · 3 comments
Closed

PyMapping improvements #302

samuelcolvin opened this issue Oct 18, 2022 · 3 comments

Comments

@samuelcolvin
Copy link
Member

Since PyO3/pyo3#2477 is released, the mapping checks should be correct.

We should therefore be able to provide some improvements to mapping logic:

  • add PyMapping to GenericMapping - avoid intermediate dict
  • some kind of rust generator type to return a generic mapping

Needs more thought, but the current situation is not great.
@tushushu
Copy link
Contributor

Hi there. I would like to work on this issue.

@tushushu tushushu mentioned this issue Oct 29, 2022
Merged
@samuelcolvin
Copy link
Member Author

Great, let me know when you have something ready for review.

@adriangb
Copy link
Member

adriangb commented Jan 5, 2023

Looks like this is now completed, thank you @tushushu !

@adriangb adriangb closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adriangb @samuelcolvin @tushushu