Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify typeshed integration test #2075

Merged
merged 1 commit into from Jan 22, 2023
Merged

Simplify typeshed integration test #2075

merged 1 commit into from Jan 22, 2023

Conversation

AlexWaygood
Copy link
Contributor

@AlexWaygood AlexWaygood commented Jan 22, 2023

None of these skips appear to be necessary nowadays; in 2023, the test passes just fine without them on typeshed.

Even if we want to keep some of these skips, the f"{tmpdir}/third_party/2and3/yaml/__init__.pyi" skip should definitely go, since that path doesn't exist in typeshed anymore :)

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #2075 (5a288a4) into main (bd78bea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2075   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          38       38           
  Lines        3089     3089           
  Branches      746      746           
=======================================
  Hits         3067     3067           
  Misses         13       13           
  Partials        9        9           

@staticdev
Copy link
Collaborator

Thanks @AlexWaygood. Now this tmuxp is giving some error.. if you can also try to fix since you have your hands dirty...

@AlexWaygood
Copy link
Contributor Author

Thanks @AlexWaygood. Now this tmuxp is giving some error.. if you can also try to fix since you have your hands dirty...

I'm sorry, I've been trying out various things for a while now and I can't figure out how to get it to pass :( None of the skips I've been trying seem to work, for some reason.

Since the tmuxp integration test is already failing on the main branch, could we leave it for now?

@staticdev
Copy link
Collaborator

@AlexWaygood sure, I will merge this one anyway. This fail is new, since less than a month ago I remember testing it and working.

@staticdev staticdev merged commit 07a516c into PyCQA:main Jan 22, 2023
@AlexWaygood AlexWaygood deleted the typeshed-integration branch January 22, 2023 15:53
@AlexWaygood
Copy link
Contributor Author

Thanks @staticdev! Sorry I couldn't be of more help :)

@staticdev
Copy link
Collaborator

No worries @AlexWaygood. I don't have time to look at it now, but maybe I can find it soon. Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants