Only call colorama.init if colorama is available
#2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticdev
requested changes
Dec 12, 2022
There was a problem hiding this comment.
@tomaarsen would you mind adding a changelog entry for 5.11.1 on changelog.md?
UPDATE: nvm.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
- Coverage 98.83% 98.80% -0.04%
==========================================
Files 38 38
Lines 3083 3084 +1
Branches 733 734 +1
==========================================
Hits 3047 3047
Misses 26 26
- Partials 10 11 +1 |
|
Apologies - I didn't see your request on time! |
|
We're hitting this with the latest 6.0.0b2: https://github.com/pytest-dev/pytest-cov/actions/runs/4284044499/jobs/7460448953 Please could you also include this in a new beta release? Also, I couldn't find any tags for the 6.x beta releases on PyPI, please could you add those? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2031
Hello!
Pull Request Overview
colorama.initifcoloramacould be imported.After this PR
After applying the reproduction steps from #2031, the command now terminates normally, as opposed to the
NameErrorfrom before.Let me know if you need anything else from me!