Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 5.11.0 #2028

Merged
merged 10 commits into from Dec 12, 2022
Merged

Prepare release 5.11.0 #2028

merged 10 commits into from Dec 12, 2022

Conversation

staticdev
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2028 (307637f) into main (9e5f8f0) will decrease coverage by 0.71%.
The diff coverage is n/a.

❗ Current head 307637f differs from pull request most recent head 8af078c. Consider uploading reports for the commit 8af078c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   99.54%   98.83%   -0.72%     
==========================================
  Files          38       38              
  Lines        3083     3083              
  Branches      733      733              
==========================================
- Hits         3069     3047      -22     
- Misses          8       26      +18     
- Partials        6       10       +4     

Copy link

@timothycrosley-stripe timothycrosley-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I would recommend we release this as 5.11.0, as major releases are discouraged unless there is major API breaking changes: https://pycqa.github.io/isort/docs/major_releases/release_policy.html major versions are just very disruptive at this point

@staticdev
Copy link
Collaborator Author

Hi! I would recommend we release this as 5.11.0, as major releases are discouraged unless there is major API breaking changes: https://pycqa.github.io/isort/docs/major_releases/release_policy.html major versions are just very disruptive at this point

You are right... will do that.

@staticdev staticdev changed the title Prepare release 6.0.0 Prepare release 5.11.0 Dec 12, 2022
@staticdev staticdev merged commit 3e99c22 into main Dec 12, 2022
@staticdev staticdev deleted the prepare-release-6.0.0 branch December 12, 2022 19:25
@staticdev staticdev restored the prepare-release-6.0.0 branch December 12, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants