Add magic trailing comma option #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legau
force-pushed
the
trailing_comma
branch
4 times, most recently
from
43282b3
to
2ad61b4
Compare
It looks like it's been merged now so perhaps you should try rerunning tests now? |
|
Any plans on when this is going to be included in a new release? |
chmeliik
added a commit
to chmeliik/cachi2
that referenced
this pull request
Oct 11, 2022
Technically this shouldn't be necessary, because isort aims to be compatible with black which respects the trailing comma. But the isort [fix][0] for this is not released yet. [0]: PyCQA/isort#1876 Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
added a commit
to containerbuildsystem/cachi2
that referenced
this pull request
Oct 11, 2022
Technically this shouldn't be necessary, because isort aims to be compatible with black which respects the trailing comma. But the isort [fix][0] for this is not released yet. [0]: PyCQA/isort#1876 Signed-off-by: Adam Cmiel <acmiel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1683, it adds the
split_on_trailing_commaoption.There's an ambiguous case when from imports are split into 2 parts like this :
In this case I made the choice to always make it split whenever one of the from imports has a trailing comma.
The integration test on airflow won't work until apache/airflow#20556 is passed