skips are not honored since isort 5.9.x #1762
Labels
bug
Something isn't working
repo_needed
Can't currently reproduce, if reproduction steps are added we will resivit this issue.
Comments
|
I have noticed the same thing happening this side. |
|
@pums974 and @grant-zietsman I'm so sorry this broke for both of you! Can you try the latest version from github and see if it is still an issue? |
timothycrosley
added
bug
|
Yeah no problem `isort . --show-config`:{
"_known_patterns": null,
"_section_comments": null,
"_skips": null,
"_skip_globs": null,
"_sorting_function": null,
"py_version": "py3",
"force_to_top": [],
"skip": [
".hg",
"__pypackages__",
"buck-out",
".pants.d",
".eggs",
"_build",
"dist",
".mypy_cache",
".venv",
".tox",
".svn",
".direnv",
".git",
"venv",
"node_modules",
"build",
".bzr",
".nox"
],
"extend_skip": [
"tmp",
"ext_bin",
"venv",
"ext"
],
"skip_glob": [],
"extend_skip_glob": [],
"skip_gitignore": true,
"line_length": 100,
"wrap_length": 0,
"line_ending": "",
"sections": [
"FUTURE",
"STDLIB",
"THIRDPARTY",
"FIRSTPARTY",
"LOCALFOLDER"
],
"no_sections": false,
"known_future_library": [
"__future__"
],
"known_third_party": [],
"known_first_party": [],
"known_local_folder": [],
"known_standard_library": [
"mmap",
"tarfile",
"hmac",
"pwd",
"shelve",
"audioop",
"getopt",
"macpath",
"uuid",
"runpy",
"optparse",
"pkgutil",
"formatter",
"ensurepip",
"test",
"dbm",
"hashlib",
"encodings",
"wave",
"winreg",
"pickletools",
"decimal",
"imaplib",
"trace",
"posixpath",
"heapq",
"chunk",
"array",
"selectors",
"curses",
"html",
"tempfile",
"statistics",
"modulefinder",
"mailbox",
"dummy_threading",
"copyreg",
"cmd",
"sqlite3",
"zipfile",
"enum",
"winsound",
"rlcompleter",
"token",
"xml",
"time",
"nis",
"pyclbr",
"netrc",
"aifc",
"syslog",
"tokenize",
"imghdr",
"concurrent",
"platform",
"lzma",
"fileinput",
"fpectl",
"resource",
"crypt",
"copy",
"subprocess",
"dataclasses",
"reprlib",
"turtledemo",
"site",
"xmlrpc",
"binascii",
"keyword",
"pty",
"faulthandler",
"wsgiref",
"abc",
"builtins",
"pathlib",
"symbol",
"gc",
"sre_compile",
"functools",
"unicodedata",
"doctest",
"logging",
"marshal",
"queue",
"ctypes",
"types",
"urllib",
"glob",
"typing",
"multiprocessing",
"asyncore",
"ipaddress",
"gzip",
"codecs",
"secrets",
"filecmp",
"_thread",
"json",
"calendar",
"quopri",
"base64",
"pydoc",
"numbers",
"errno",
"locale",
"fcntl",
"inspect",
"codeop",
"itertools",
"fnmatch",
"getpass",
"_dummy_thread",
"fractions",
"tty",
"contextvars",
"sndhdr",
"plistlib",
"difflib",
"posix",
"bdb",
"math",
"distutils",
"http",
"grp",
"dis",
"profile",
"cmath",
"pdb",
"pprint",
"socket",
"telnetlib",
"ntpath",
"graphlib",
"py_compile",
"symtable",
"timeit",
"asynchat",
"cgitb",
"smtpd",
"gettext",
"nntplib",
"turtle",
"ftplib",
"uu",
"sre_constants",
"signal",
"readline",
"struct",
"poplib",
"mailcap",
"termios",
"spwd",
"sys",
"compileall",
"configparser",
"textwrap",
"io",
"operator",
"linecache",
"smtplib",
"stat",
"sysconfig",
"os",
"sre",
"select",
"code",
"parser",
"bisect",
"tracemalloc",
"socketserver",
"webbrowser",
"binhex",
"colorsys",
"ssl",
"sunau",
"asyncio",
"cProfile",
"mimetypes",
"ast",
"threading",
"zlib",
"lib2to3",
"contextlib",
"random",
"sre_parse",
"zoneinfo",
"bz2",
"zipapp",
"xdrlib",
"string",
"collections",
"atexit",
"msilib",
"weakref",
"stringprep",
"imp",
"re",
"pickle",
"warnings",
"importlib",
"tabnanny",
"sched",
"shlex",
"tkinter",
"zipimport",
"cgi",
"ossaudiodev",
"msvcrt",
"pipes",
"shutil",
"csv",
"datetime",
"email",
"pstats",
"venv",
"unittest",
"traceback",
"argparse"
],
"extra_standard_library": [],
"known_other": {},
"multi_line_output": "VERTICAL_HANGING_INDENT",
"forced_separate": [],
"indent": " ",
"comment_prefix": " #",
"length_sort": false,
"length_sort_straight": false,
"length_sort_sections": [],
"add_imports": [],
"remove_imports": [],
"append_only": false,
"reverse_relative": false,
"force_single_line": false,
"single_line_exclusions": [],
"default_section": "THIRDPARTY",
"import_headings": {},
"balanced_wrapping": false,
"use_parentheses": true,
"order_by_type": true,
"atomic": false,
"lines_after_imports": -1,
"lines_between_sections": 1,
"lines_between_types": 0,
"combine_as_imports": false,
"combine_star": false,
"include_trailing_comma": true,
"from_first": false,
"verbose": false,
"quiet": false,
"force_adds": false,
"force_alphabetical_sort_within_sections": false,
"force_alphabetical_sort": false,
"force_grid_wrap": 0,
"force_sort_within_sections": false,
"lexicographical": false,
"group_by_package": false,
"ignore_whitespace": false,
"no_lines_before": [],
"no_inline_sort": false,
"ignore_comments": false,
"case_sensitive": false,
"sources": [
{
"py_version": "py3",
"force_to_top": [],
"skip": [
".hg",
"__pypackages__",
"buck-out",
".pants.d",
".eggs",
"_build",
"dist",
".mypy_cache",
".venv",
".tox",
".svn",
".direnv",
".git",
"venv",
"node_modules",
"build",
".bzr",
".nox"
],
"extend_skip": [],
"skip_glob": [],
"extend_skip_glob": [],
"skip_gitignore": false,
"line_length": 79,
"wrap_length": 0,
"line_ending": "",
"sections": [
"FUTURE",
"STDLIB",
"THIRDPARTY",
"FIRSTPARTY",
"LOCALFOLDER"
],
"no_sections": false,
"known_future_library": [
"__future__"
],
"known_third_party": [],
"known_first_party": [],
"known_local_folder": [],
"known_standard_library": [
"mmap",
"tarfile",
"hmac",
"pwd",
"shelve",
"audioop",
"getopt",
"macpath",
"uuid",
"runpy",
"optparse",
"pkgutil",
"formatter",
"ensurepip",
"test",
"dbm",
"hashlib",
"encodings",
"wave",
"winreg",
"pickletools",
"decimal",
"imaplib",
"trace",
"posixpath",
"heapq",
"chunk",
"array",
"selectors",
"curses",
"html",
"tempfile",
"statistics",
"modulefinder",
"mailbox",
"dummy_threading",
"copyreg",
"cmd",
"sqlite3",
"zipfile",
"enum",
"winsound",
"rlcompleter",
"token",
"xml",
"time",
"nis",
"pyclbr",
"netrc",
"aifc",
"syslog",
"tokenize",
"imghdr",
"concurrent",
"platform",
"lzma",
"fileinput",
"fpectl",
"resource",
"crypt",
"copy",
"subprocess",
"dataclasses",
"reprlib",
"turtledemo",
"site",
"xmlrpc",
"binascii",
"keyword",
"pty",
"faulthandler",
"wsgiref",
"abc",
"builtins",
"pathlib",
"symbol",
"gc",
"sre_compile",
"functools",
"unicodedata",
"doctest",
"logging",
"marshal",
"queue",
"ctypes",
"types",
"urllib",
"glob",
"typing",
"multiprocessing",
"asyncore",
"ipaddress",
"gzip",
"codecs",
"secrets",
"filecmp",
"_thread",
"json",
"calendar",
"quopri",
"base64",
"pydoc",
"numbers",
"errno",
"locale",
"fcntl",
"inspect",
"codeop",
"itertools",
"fnmatch",
"getpass",
"_dummy_thread",
"fractions",
"tty",
"contextvars",
"sndhdr",
"plistlib",
"difflib",
"posix",
"bdb",
"math",
"distutils",
"http",
"grp",
"dis",
"profile",
"cmath",
"pdb",
"pprint",
"socket",
"telnetlib",
"ntpath",
"graphlib",
"py_compile",
"symtable",
"timeit",
"asynchat",
"cgitb",
"smtpd",
"gettext",
"nntplib",
"turtle",
"ftplib",
"uu",
"sre_constants",
"signal",
"readline",
"struct",
"poplib",
"mailcap",
"termios",
"spwd",
"sys",
"compileall",
"configparser",
"textwrap",
"io",
"operator",
"linecache",
"smtplib",
"stat",
"sysconfig",
"os",
"sre",
"select",
"code",
"parser",
"bisect",
"tracemalloc",
"socketserver",
"webbrowser",
"binhex",
"colorsys",
"ssl",
"sunau",
"asyncio",
"cProfile",
"mimetypes",
"ast",
"threading",
"zlib",
"lib2to3",
"contextlib",
"random",
"sre_parse",
"zoneinfo",
"bz2",
"zipapp",
"xdrlib",
"string",
"collections",
"atexit",
"msilib",
"weakref",
"stringprep",
"imp",
"re",
"pickle",
"warnings",
"importlib",
"tabnanny",
"sched",
"shlex",
"tkinter",
"zipimport",
"cgi",
"ossaudiodev",
"msvcrt",
"pipes",
"shutil",
"csv",
"datetime",
"email",
"pstats",
"venv",
"unittest",
"traceback",
"argparse"
],
"extra_standard_library": [],
"known_other": {},
"multi_line_output": "GRID",
"forced_separate": [],
"indent": " ",
"comment_prefix": " #",
"length_sort": false,
"length_sort_straight": false,
"length_sort_sections": [],
"add_imports": [],
"remove_imports": [],
"append_only": false,
"reverse_relative": false,
"force_single_line": false,
"single_line_exclusions": [],
"default_section": "THIRDPARTY",
"import_headings": {},
"balanced_wrapping": false,
"use_parentheses": false,
"order_by_type": true,
"atomic": false,
"lines_after_imports": -1,
"lines_between_sections": 1,
"lines_between_types": 0,
"combine_as_imports": false,
"combine_star": false,
"include_trailing_comma": false,
"from_first": false,
"verbose": false,
"quiet": false,
"force_adds": false,
"force_alphabetical_sort_within_sections": false,
"force_alphabetical_sort": false,
"force_grid_wrap": 0,
"force_sort_within_sections": false,
"lexicographical": false,
"group_by_package": false,
"ignore_whitespace": false,
"no_lines_before": [],
"no_inline_sort": false,
"ignore_comments": false,
"case_sensitive": false,
"sources": [],
"virtual_env": "",
"conda_env": "",
"ensure_newline_before_comments": false,
"directory": "",
"profile": "",
"honor_noqa": false,
"src_paths": [],
"old_finders": false,
"remove_redundant_aliases": false,
"float_to_top": false,
"filter_files": false,
"formatter": "",
"formatting_function": null,
"color_output": false,
"treat_comments_as_code": [],
"treat_all_comments_as_code": false,
"supported_extensions": [
"pxd",
"pyi",
"py",
"pyx"
],
"blocked_extensions": [
"pex"
],
"constants": [],
"classes": [],
"variables": [],
"dedup_headings": false,
"only_sections": false,
"only_modified": false,
"combine_straight_imports": false,
"auto_identify_namespace_packages": true,
"namespace_packages": [],
"follow_links": true,
"indented_import_headings": true,
"honor_case_in_force_sorted_sections": false,
"sort_relative_in_force_sorted_sections": false,
"overwrite_in_place": false,
"reverse_sort": false,
"star_first": false,
"git_ignore": {},
"format_error": "{error}: {message}",
"format_success": "{success}: {message}",
"sort_order": "natural",
"source": "defaults"
},
{
"multi_line_output": 3,
"include_trailing_comma": true,
"force_grid_wrap": 0,
"use_parentheses": true,
"ensure_newline_before_comments": true,
"line_length": 88,
"source": "black profile"
},
{
"profile": "black",
"multi_line_output": "VERTICAL_HANGING_INDENT",
"line_length": 100,
"extend_skip": [
"tmp",
"ext_bin",
"ext"
],
"src_paths": [
"pymcac"
],
"skip_gitignore": true,
"source": "/Data/WORK/Projets/SRC/MCAC/pyproject.toml"
}
],
"virtual_env": "",
"conda_env": "",
"ensure_newline_before_comments": true,
"directory": "/Data/WORK/Projets/SRC/MCAC",
"profile": "black",
"honor_noqa": false,
"src_paths": [
"/Data/WORK/Projets/SRC/MCAC/pymcac"
],
"old_finders": false,
"remove_redundant_aliases": false,
"float_to_top": false,
"filter_files": false,
"formatter": "",
"formatting_function": null,
"color_output": false,
"treat_comments_as_code": [],
"treat_all_comments_as_code": false,
"supported_extensions": [
"pxd",
"pyi",
"py",
"pyx"
],
"blocked_extensions": [
"pex"
],
"constants": [],
"classes": [],
"variables": [],
"dedup_headings": false,
"only_sections": false,
"only_modified": false,
"combine_straight_imports": false,
"auto_identify_namespace_packages": true,
"namespace_packages": [],
"follow_links": true,
"indented_import_headings": true,
"honor_case_in_force_sorted_sections": false,
"sort_relative_in_force_sorted_sections": false,
"overwrite_in_place": false,
"reverse_sort": false,
"star_first": false,
"git_ignore": {},
"format_error": "{error}: {message}",
"format_success": "{success}: {message}",
"sort_order": "natural"
}`pyproject.toml`:[tool.isort]
profile = "black"
multi_line_output = 3
line_length = 100
extend_skip = [
"tmp",
"ext",
"ext_bin",
]
skip_gitignore = trueI just realize that with And I have the same results the current git version (15234f8) |
|
I ran this with the latest version (installed from git) and these are the results that I am seeing. isort --check .isort . --show-configcat .gitignore |
|
I also have this issue with isort 5.9.1. I installed the latest version ( 23d708e ) from git & the issue persisted. isort . --show-config
.isort.cfg
The file specified with skip= is skipped as expected but the files & folders in .gitignore aren't skipped. .gitignore
|
|
Same issue here when using my entire |
|
I also experienced this as well with I observed this behavior on Windows and macOS. Reverting to
[tool.isort]
profile = "black"
line_length = 99
force_sort_within_sections = true
skip_gitignore = true
|
|
I'm sorry everyone is continuing to experience this! There have been 2 major fixes against the git ignore behavior in the main branch since this was last experienced (I myself have not been able to get this to happen). Can someone who is experiencing this issue try against latest main and see if it is resolved? |
|
Tested pip install from current main and it seems to have fixed it for me, thanks |
|
@jaidisido thanks for testing! 5.9.2 has been pushed which should resolve this issue. |
|
Hi, where If I put my `isort . --show-config`:{
"_known_patterns": null,
"_section_comments": null,
"_skips": null,
"_skip_globs": null,
"_sorting_function": null,
"py_version": "py3",
"force_to_top": [],
"skip": [
"__pypackages__",
".tox",
"dist",
".nox",
".venv",
"build",
".mypy_cache",
".direnv",
".bzr",
"venv",
".eggs",
"buck-out",
".git",
"node_modules",
".hg",
".svn",
"_build",
".pants.d"
],
"extend_skip": [
"other_project"
],
"skip_glob": [],
"extend_skip_glob": [],
"skip_gitignore": true,
"line_length": 100,
"wrap_length": 0,
"line_ending": "",
"sections": [
"FUTURE",
"STDLIB",
"THIRDPARTY",
"FIRSTPARTY",
"LOCALFOLDER"
],
"no_sections": false,
"known_future_library": [
"__future__"
],
"known_third_party": [],
"known_first_party": [],
"known_local_folder": [],
"known_standard_library": [
"shelve",
"formatter",
"struct",
"pstats",
"sys",
"imp",
"imaplib",
"pkgutil",
"trace",
"pprint",
"fcntl",
"symtable",
"rlcompleter",
"msilib",
"tempfile",
"tarfile",
"json",
"msvcrt",
"pickle",
"uu",
"grp",
"statistics",
"keyword",
"cmd",
"difflib",
"string",
"hashlib",
"argparse",
"site",
"itertools",
"pipes",
"tokenize",
"faulthandler",
"tracemalloc",
"cmath",
"smtplib",
"datetime",
"ast",
"winreg",
"aifc",
"netrc",
"pydoc",
"ntpath",
"subprocess",
"zipimport",
"importlib",
"zipapp",
"curses",
"_dummy_thread",
"resource",
"multiprocessing",
"bdb",
"email",
"gettext",
"fractions",
"tkinter",
"gc",
"select",
"unittest",
"warnings",
"timeit",
"sqlite3",
"encodings",
"zoneinfo",
"reprlib",
"math",
"chunk",
"readline",
"pyclbr",
"binascii",
"binhex",
"inspect",
"random",
"zipfile",
"imghdr",
"xmlrpc",
"operator",
"sre",
"typing",
"atexit",
"pty",
"stat",
"ctypes",
"compileall",
"urllib",
"wsgiref",
"asyncio",
"html",
"macpath",
"sre_compile",
"csv",
"crypt",
"copyreg",
"abc",
"types",
"zlib",
"lib2to3",
"linecache",
"shlex",
"dataclasses",
"poplib",
"mimetypes",
"io",
"smtpd",
"colorsys",
"pwd",
"dbm",
"contextlib",
"glob",
"unicodedata",
"concurrent",
"array",
"hmac",
"asyncore",
"graphlib",
"time",
"venv",
"profile",
"builtins",
"ensurepip",
"sunau",
"bz2",
"mmap",
"sched",
"http",
"queue",
"sre_parse",
"posix",
"uuid",
"contextvars",
"mailcap",
"cgitb",
"telnetlib",
"mailbox",
"token",
"marshal",
"doctest",
"wave",
"functools",
"copy",
"nntplib",
"ossaudiodev",
"fnmatch",
"termios",
"selectors",
"pathlib",
"tabnanny",
"tty",
"sndhdr",
"fileinput",
"posixpath",
"locale",
"webbrowser",
"enum",
"dis",
"quopri",
"codeop",
"numbers",
"threading",
"secrets",
"calendar",
"ssl",
"base64",
"heapq",
"collections",
"turtledemo",
"getpass",
"stringprep",
"ftplib",
"xdrlib",
"lzma",
"_thread",
"test",
"xml",
"sre_constants",
"asynchat",
"socketserver",
"pdb",
"nis",
"symbol",
"codecs",
"os",
"filecmp",
"textwrap",
"code",
"getopt",
"re",
"logging",
"plistlib",
"parser",
"cProfile",
"dummy_threading",
"bisect",
"shutil",
"py_compile",
"socket",
"configparser",
"sysconfig",
"distutils",
"gzip",
"pickletools",
"optparse",
"turtle",
"runpy",
"syslog",
"fpectl",
"ipaddress",
"errno",
"modulefinder",
"winsound",
"cgi",
"weakref",
"spwd",
"audioop",
"traceback",
"signal",
"decimal",
"platform"
],
"extra_standard_library": [],
"known_other": {},
"multi_line_output": "VERTICAL_HANGING_INDENT",
"forced_separate": [],
"indent": " ",
"comment_prefix": " #",
"length_sort": false,
"length_sort_straight": false,
"length_sort_sections": [],
"add_imports": [],
"remove_imports": [],
"append_only": false,
"reverse_relative": false,
"force_single_line": false,
"single_line_exclusions": [],
"default_section": "THIRDPARTY",
"import_headings": {},
"balanced_wrapping": false,
"use_parentheses": true,
"order_by_type": true,
"atomic": false,
"lines_after_imports": -1,
"lines_between_sections": 1,
"lines_between_types": 0,
"combine_as_imports": false,
"combine_star": false,
"include_trailing_comma": true,
"from_first": false,
"verbose": false,
"quiet": false,
"force_adds": false,
"force_alphabetical_sort_within_sections": false,
"force_alphabetical_sort": false,
"force_grid_wrap": 0,
"force_sort_within_sections": false,
"lexicographical": false,
"group_by_package": false,
"ignore_whitespace": false,
"no_lines_before": [],
"no_inline_sort": false,
"ignore_comments": false,
"case_sensitive": false,
"sources": [
{
"py_version": "py3",
"force_to_top": [],
"skip": [
"__pypackages__",
".tox",
"dist",
".nox",
".venv",
"build",
".mypy_cache",
".direnv",
".bzr",
"venv",
".eggs",
"buck-out",
".git",
"node_modules",
".hg",
".svn",
"_build",
".pants.d"
],
"extend_skip": [],
"skip_glob": [],
"extend_skip_glob": [],
"skip_gitignore": false,
"line_length": 79,
"wrap_length": 0,
"line_ending": "",
"sections": [
"FUTURE",
"STDLIB",
"THIRDPARTY",
"FIRSTPARTY",
"LOCALFOLDER"
],
"no_sections": false,
"known_future_library": [
"__future__"
],
"known_third_party": [],
"known_first_party": [],
"known_local_folder": [],
"known_standard_library": [
"shelve",
"formatter",
"struct",
"pstats",
"sys",
"imp",
"imaplib",
"pkgutil",
"trace",
"pprint",
"fcntl",
"symtable",
"rlcompleter",
"msilib",
"tempfile",
"tarfile",
"json",
"msvcrt",
"pickle",
"uu",
"grp",
"statistics",
"keyword",
"cmd",
"difflib",
"string",
"hashlib",
"argparse",
"site",
"itertools",
"pipes",
"tokenize",
"faulthandler",
"tracemalloc",
"cmath",
"smtplib",
"datetime",
"ast",
"winreg",
"aifc",
"netrc",
"pydoc",
"ntpath",
"subprocess",
"zipimport",
"importlib",
"zipapp",
"curses",
"_dummy_thread",
"resource",
"multiprocessing",
"bdb",
"email",
"gettext",
"fractions",
"tkinter",
"gc",
"select",
"unittest",
"warnings",
"timeit",
"sqlite3",
"encodings",
"zoneinfo",
"reprlib",
"math",
"chunk",
"readline",
"pyclbr",
"binascii",
"binhex",
"inspect",
"random",
"zipfile",
"imghdr",
"xmlrpc",
"operator",
"sre",
"typing",
"atexit",
"pty",
"stat",
"ctypes",
"compileall",
"urllib",
"wsgiref",
"asyncio",
"html",
"macpath",
"sre_compile",
"csv",
"crypt",
"copyreg",
"abc",
"types",
"zlib",
"lib2to3",
"linecache",
"shlex",
"dataclasses",
"poplib",
"mimetypes",
"io",
"smtpd",
"colorsys",
"pwd",
"dbm",
"contextlib",
"glob",
"unicodedata",
"concurrent",
"array",
"hmac",
"asyncore",
"graphlib",
"time",
"venv",
"profile",
"builtins",
"ensurepip",
"sunau",
"bz2",
"mmap",
"sched",
"http",
"queue",
"sre_parse",
"posix",
"uuid",
"contextvars",
"mailcap",
"cgitb",
"telnetlib",
"mailbox",
"token",
"marshal",
"doctest",
"wave",
"functools",
"copy",
"nntplib",
"ossaudiodev",
"fnmatch",
"termios",
"selectors",
"pathlib",
"tabnanny",
"tty",
"sndhdr",
"fileinput",
"posixpath",
"locale",
"webbrowser",
"enum",
"dis",
"quopri",
"codeop",
"numbers",
"threading",
"secrets",
"calendar",
"ssl",
"base64",
"heapq",
"collections",
"turtledemo",
"getpass",
"stringprep",
"ftplib",
"xdrlib",
"lzma",
"_thread",
"test",
"xml",
"sre_constants",
"asynchat",
"socketserver",
"pdb",
"nis",
"symbol",
"codecs",
"os",
"filecmp",
"textwrap",
"code",
"getopt",
"re",
"logging",
"plistlib",
"parser",
"cProfile",
"dummy_threading",
"bisect",
"shutil",
"py_compile",
"socket",
"configparser",
"sysconfig",
"distutils",
"gzip",
"pickletools",
"optparse",
"turtle",
"runpy",
"syslog",
"fpectl",
"ipaddress",
"errno",
"modulefinder",
"winsound",
"cgi",
"weakref",
"spwd",
"audioop",
"traceback",
"signal",
"decimal",
"platform"
],
"extra_standard_library": [],
"known_other": {},
"multi_line_output": "GRID",
"forced_separate": [],
"indent": " ",
"comment_prefix": " #",
"length_sort": false,
"length_sort_straight": false,
"length_sort_sections": [],
"add_imports": [],
"remove_imports": [],
"append_only": false,
"reverse_relative": false,
"force_single_line": false,
"single_line_exclusions": [],
"default_section": "THIRDPARTY",
"import_headings": {},
"balanced_wrapping": false,
"use_parentheses": false,
"order_by_type": true,
"atomic": false,
"lines_after_imports": -1,
"lines_between_sections": 1,
"lines_between_types": 0,
"combine_as_imports": false,
"combine_star": false,
"include_trailing_comma": false,
"from_first": false,
"verbose": false,
"quiet": false,
"force_adds": false,
"force_alphabetical_sort_within_sections": false,
"force_alphabetical_sort": false,
"force_grid_wrap": 0,
"force_sort_within_sections": false,
"lexicographical": false,
"group_by_package": false,
"ignore_whitespace": false,
"no_lines_before": [],
"no_inline_sort": false,
"ignore_comments": false,
"case_sensitive": false,
"sources": [],
"virtual_env": "",
"conda_env": "",
"ensure_newline_before_comments": false,
"directory": "",
"profile": "",
"honor_noqa": false,
"src_paths": [],
"old_finders": false,
"remove_redundant_aliases": false,
"float_to_top": false,
"filter_files": false,
"formatter": "",
"formatting_function": null,
"color_output": false,
"treat_comments_as_code": [],
"treat_all_comments_as_code": false,
"supported_extensions": [
"py",
"pyi",
"pxd",
"pyx"
],
"blocked_extensions": [
"pex"
],
"constants": [],
"classes": [],
"variables": [],
"dedup_headings": false,
"only_sections": false,
"only_modified": false,
"combine_straight_imports": false,
"auto_identify_namespace_packages": true,
"namespace_packages": [],
"follow_links": true,
"indented_import_headings": true,
"honor_case_in_force_sorted_sections": false,
"sort_relative_in_force_sorted_sections": false,
"overwrite_in_place": false,
"reverse_sort": false,
"star_first": false,
"git_ignore": {},
"format_error": "{error}: {message}",
"format_success": "{success}: {message}",
"sort_order": "natural",
"source": "defaults"
},
{
"multi_line_output": 3,
"include_trailing_comma": true,
"force_grid_wrap": 0,
"use_parentheses": true,
"ensure_newline_before_comments": true,
"line_length": 88,
"source": "black profile"
},
{
"profile": "black",
"multi_line_output": "VERTICAL_HANGING_INDENT",
"line_length": 100,
"extend_skip": [
"other_project"
],
"skip_gitignore": true,
"source": "/some/path/pyproject.toml"
}
],
"virtual_env": "",
"conda_env": "",
"ensure_newline_before_comments": true,
"directory": "/some/path",
"profile": "black",
"honor_noqa": false,
"src_paths": [
"/some/path/src",
"/some/path"
],
"old_finders": false,
"remove_redundant_aliases": false,
"float_to_top": false,
"filter_files": false,
"formatter": "",
"formatting_function": null,
"color_output": false,
"treat_comments_as_code": [],
"treat_all_comments_as_code": false,
"supported_extensions": [
"py",
"pyi",
"pxd",
"pyx"
],
"blocked_extensions": [
"pex"
],
"constants": [],
"classes": [],
"variables": [],
"dedup_headings": false,
"only_sections": false,
"only_modified": false,
"combine_straight_imports": false,
"auto_identify_namespace_packages": true,
"namespace_packages": [],
"follow_links": true,
"indented_import_headings": true,
"honor_case_in_force_sorted_sections": false,
"sort_relative_in_force_sorted_sections": false,
"overwrite_in_place": false,
"reverse_sort": false,
"star_first": false,
"git_ignore": {},
"format_error": "{error}: {message}",
"format_success": "{success}: {message}",
"sort_order": "natural"
}`pyproject.toml`:[tool.isort]
profile = "black"
multi_line_output = 3
line_length = 100
extend_skip = [
"other_project",
]
skip_gitignore = true |
|
@timothycrosley 5.9.2 seemed to fix the issue for me. Though when I ran with My config: [tool.isort]
profile = "black"
line_length = 99
force_sort_within_sections = true
src_paths = ["config", "api"]
skip_gitignore = trueLet me know if you think I should open a separate issue about this. |
|
@johnthagen, good call out! Currently, that message isn't aware of why a skip happened. I've done the minimal thing of updating it to mention the gitignore possibility: 6c1ec9a but making it know why a file was skipped would require a bit more of a refactoring if it is needed. |
Do you want me to open a different issue ? |
To me that makes it clear enough (just knowing that it could be possibility). I don't think there is huge value is trying to track why each item was skipped. Thanks for the quick response and fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using
isortwith my project for some time now, thank you for this project !Everything was working well with 5.8.0 but with 5.9.0 I have the error
And with the version 5.9.1,
extend_skipandskip_gitignoreare not honored andisortgoes into myvenvfolder where it shouldn't go.Thank you for looking into this
The text was updated successfully, but these errors were encountered: