Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort 5.5.4 introduces syntax error by removing closing paren #1539

Closed
maxdjohnson opened this issue Oct 7, 2020 · 2 comments
Closed

isort 5.5.4 introduces syntax error by removing closing paren #1539

maxdjohnson opened this issue Oct 7, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@maxdjohnson
Copy link

Hello,

I've found what I believe to be a bug in isort. This is the minimum case I can find that reproduces the issue:

"""Foobar
    from {}""".format(
    "bar",
)

Saving this to a file t.py and running isort on it does the following for me

> isort t.py
Fixing /Users/mjohnson/t.py
> cat t.py
"""Foobar
    from {}""".format(
    "bar",

Note the missing closing paren from the last line, which is a syntax error. I have tested this on a fresh virtualenv with only isort==5.5.4 with both python 3.6 and 3.8.

@timothycrosley timothycrosley added the bug Something isn't working label Oct 8, 2020
@timothycrosley
Copy link
Member

Thank you for reporting! this has been fixed in isort 5.5.5+ with several additional regression tests added.

~Timothy

@maxdjohnson
Copy link
Author

Appreciate the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants