New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parallel execution collecting a SyntaxError #1410

Merged

asottile merged 1 commit into main from parallel-syntax-error

Oct 11, 2021

Member

asottile commented Oct 11, 2021

Resolves #1408


          fix parallel execution collecting a SyntaxError

aa54693

asottile commented

View reviewed changes

src/flake8/checker.py

@@ @@ -588,7 +590,7 @@ def process_tokens(self): @@
                           self.run_physical_checks(file_processor.lines[-1])
                           self.run_logical_checks()
-                  def run_checks(self):
+                  def run_checks(self) -> Tuple[str, Results, Dict[str, int]]:

Member Author

asottile Oct 11, 2021

we don't have a great way of testing the parallel mode in integration so I leveraged the type checker as a "test" instead

asottile merged commit 0fac346 into main

asottile deleted the parallel-syntax-error branch

October 11, 2021 12:32

asottile modified the milestones: 4.0.0, 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment