From 49fe68c683d21457cc906bed19f38095e0124bf0 Mon Sep 17 00:00:00 2001
From: Adel Haddad <26027314+adehad@users.noreply.github.com>
Date: Tue, 26 Jul 2022 18:37:14 +0100
Subject: [PATCH] ensure `None` is handled correctly in `search_issues()`
 (#1434)

---
 jira/client.py                | 2 ++
 tests/resources/test_issue.py | 9 ++++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/jira/client.py b/jira/client.py
index 8bce0fe64..de0a11040 100644
--- a/jira/client.py
+++ b/jira/client.py
@@ -2930,6 +2930,8 @@ def search_issues(
         """
         if isinstance(fields, str):
             fields = fields.split(",")
+        elif fields is None:
+            fields = ["*all"]
 
         # this will translate JQL field names to REST API Name
         # most people do know the JQL names so this will help them use the API easier
diff --git a/tests/resources/test_issue.py b/tests/resources/test_issue.py
index d70707e23..1f465b9b2 100644
--- a/tests/resources/test_issue.py
+++ b/tests/resources/test_issue.py
@@ -37,10 +37,17 @@ def test_issue_search_only_includes_provided_fields(self):
         self.assertFalse(hasattr(issues[0].fields, "reporter"))
 
     def test_issue_search_default_behaviour_included_fields(self):
-        issues = self.jira.search_issues("key=%s" % self.issue_1)
+        search_str = f"key={self.issue_1}"
+        issues = self.jira.search_issues(search_str)
         self.assertTrue(hasattr(issues[0].fields, "reporter"))
         self.assertTrue(hasattr(issues[0].fields, "comment"))
 
+        # fields=None should be valid and return all fields (ie. default behavior)
+        self.assertEqual(
+            self.jira.search_issues(search_str),
+            self.jira.search_issues(search_str, fields=None),
+        )
+
     def test_issue_get_field(self):
         issue = self.jira.issue(self.issue_1)
         self.assertEqual(