Problem in gajim IM with pyopenssl 17.4.0 in ArchLinux

[Genues]

Hi!
Please help solved problem in gajim IM with pyopenssl 17.4.0 in ArchLinux:
$ gajim
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nbxmpp/idlequeue.py", line 549, in _process_events
return IdleQueue._process_events(self, fd, flags)
File "/usr/lib/python2.7/site-packages/nbxmpp/idlequeue.py", line 409, in _process_events
obj.pollin()
File "/usr/lib/python2.7/site-packages/nbxmpp/transports_nb.py", line 446, in pollin
self._do_receive()
File "/usr/lib/python2.7/site-packages/nbxmpp/transports_nb.py", line 669, in _do_receive
self._on_receive(received)
File "/usr/lib/python2.7/site-packages/nbxmpp/transports_nb.py", line 683, in _on_receive
self.on_receive(data)
File "/usr/lib/python2.7/site-packages/nbxmpp/client_nb.py", line 332, in
self.onreceive(lambda _data:self._xmpp_connect_machine(mode, _data))
File "/usr/lib/python2.7/site-packages/nbxmpp/client_nb.py", line 385, in _xmpp_connect_machine
self._xmpp_connect_machine(mode='STREAM_STARTED')
File "/usr/lib/python2.7/site-packages/nbxmpp/client_nb.py", line 388, in _xmpp_connect_machine
self._on_stream_start()
File "/usr/lib/python2.7/site-packages/nbxmpp/client_nb.py", line 424, in _on_stream_start
self._on_connect()
File "/usr/lib/python2.7/site-packages/nbxmpp/client_nb.py", line 461, in _on_connect
self.on_connect(self, self.connected)
File "/usr/lib/python2.7/site-packages/gajim/common/connection.py", line 1428, in _connect_success
return self.connection_accepted(con, con_type)
File "/usr/lib/python2.7/site-packages/gajim/common/connection.py", line 1498, in connection_accepted
hostname) and '100' not in gajim.config.get_per('accounts',
File "/usr/lib/python2.7/site-packages/gajim/common/check_X509.py", line 171, in check_certificate
subject = cert.get_subject()
File "/usr/lib/python2.7/site-packages/OpenSSL/crypto.py", line 1438, in get_subject
self._subject_invalidator.add(name)
AttributeError: 'X509' object has no attribute '_subject_invalidator'

Version 17.3.0 work fine.

[reaperhulk]

This looks likely to be a situation where you have multiple copies of pyOpenSSL installed and your Python is loading part of each of them.

[Genues]

@reaperhulk How to check it? Why if i going back to 17.3.0 gajim run fine?
In my system installed two pyopenssl - for Python2 and Python3.

[reaperhulk]

Did you install pyopenssl via arch's package manager or via pip?

[Genues]

@reaperhulk arch's package manager - pacman

[reaperhulk]

Hmm, okay. Could you look at /usr/lib/python2.7/site-packages/OpenSSL/crypto.py and confirm that _subject_invalidator is set in the __init__ for the X509 class?

I'll be very surprised if it's not... Do you have any other copies of crypto.py on your system?

[Genues]

@reaperhulk

class X509(object):
    """
    An X.509 certificate.
    """
    def __init__(self):
        x509 = _lib.X509_new()
        _openssl_assert(x509 != _ffi.NULL)
        self._x509 = _ffi.gc(x509, _lib.X509_free)
            
        self._issuer_invalidator = _X509NameInvalidator()
        self._subject_invalidator = _X509NameInvalidator()

I not install any other pyopenssl packages.

[alex]

@reaperhulk it's our bug: https://github.com/pyca/pyopenssl/blob/master/src/OpenSSL/SSL.py#L312-L313

note to self, figure out the memory management here: https://github.com/pyca/pyopenssl/blob/master/src/OpenSSL/crypto.py#L1093

[reaperhulk]

@alex sigh, my __new__ guess on IRC was right, but in our own repo 👎

[Genues]

Can i fix something any files for gajim works?

[reaperhulk]

@Genues I'm writing a fix now. In addition to this bug the memory handling here is wrong so we need to add some new things to cryptography as well.

[Genues]

@reaperhulk Thank you.

[reaperhulk]

This should be resolved in 17.5.0