Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X509Extension constructor documentation is misleading #1173

Closed
davidben opened this issue Dec 29, 2022 · 0 comments
Closed

X509Extension constructor documentation is misleading #1173

davidben opened this issue Dec 29, 2022 · 0 comments

Comments

@davidben
Copy link
Contributor

X509Extension documentation says it takes a "value (bytes) – The value of the extension.", which reads as it if takes the raw bytes of the extension. (The relevant field in X.509 is even called extnValue.) However, it seems to actually pass it into OpenSSL's ad-hoc string-based config-file syntax for specifying extensions.
https://www.pyopenssl.org/en/stable/api/crypto.html#x509extension-objects

alex added a commit that referenced this issue Dec 29, 2022
make the x509extension docs more clear
@mhils mhils closed this as completed in 3052995 Dec 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant