Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-manifest gets confused by docs/_build #732

Closed
joernheissler opened this issue Dec 28, 2021 · 1 comment
Closed

check-manifest gets confused by docs/_build #732

joernheissler opened this issue Dec 28, 2021 · 1 comment

Comments

@joernheissler
Copy link

First build the docs with tox -e docs, then do meta checks:

$ tox -e meta
...
meta run-test: commands[2] | check-manifest . --ignore .travis.yml
lists of files in version control and sdist do not match!
missing from VCS:
  docs/_build/html/_downloads/44b911a7f4a40c3279763302410cf51d/argondriver.py
  docs/_build/html/_images/ed25519.png
  docs/_build/html/_static/ed25519.png
  docs/_build/html/_static/file.png
  docs/_build/html/_static/minus.png
  docs/_build/html/_static/plus.png

I suspect that MANIFEST.in needs a change, e.g. exclude docs/_build/**. But I'm not familiar with MANIFEST and it doesn't behave how I understand the docs.
@reaperhulk
Copy link
Member

Yeah just need to add a prune docs/_build into the MANIFEST.in to have it automatically remove that.

reaperhulk added a commit to reaperhulk/pynacl that referenced this issue Jan 3, 2022
@reaperhulk
add a prune to fix pyca#732
b9ee689
@alex alex closed this as completed in 61ddf15 Jan 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reaperhulk @joernheissler