Mark size constants as ClassVars
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
previously approved these changes
Dec 23, 2021
|
Looks like this needs a |
I guess I wasn't looking out for this before since there weren't any mypy errors. Nice to have though.
DMRobertson
force-pushed
the
mypy-classvars
branch
from
b68c464
to
28dfd46
Compare
alex
approved these changes
Dec 23, 2021
Not especially; I've just got into the habit of checking that CI completes successfully before anyone spends the time to review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess I wasn't looking out for this before since there weren't any
mypy errors. Nice to have though.