Annotations for tests, part 2 #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fix here was to add an assertion to some bare equality tests. The other changes are just clarifications.
This doesn't exist in the stdbib until Python 3.8, and I don't think it's worth the faff to pull in `typing_extensions` just to annotate test source code.
Merged
reaperhulk
approved these changes
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now to see how CI runs. (Sorry, I'm lazy and would rather have GHA run the test suite!)Much like #725.
I didn't spot much of interest here. In ec3dc04 there were a couple of tests which had a naked equality test without an
assert, which I'm guessing isn't intentional.