Annotations in tests, part 1
#725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
mypy-tests
branch
from
04b6b88
to
592ea70
Compare
reaperhulk
approved these changes
Dec 23, 2021
| @@ -285,6 +323,7 @@ def test_box_failed_decryption( | |||
| def test_box_wrong_length(): | |||
| with pytest.raises(ValueError): | |||
| PublicKey(b"") | |||
| # TODO: should the below raise a ValueError? | |||
There was a problem hiding this comment.
A good one to look at in the future, but fine to preserve behavior for now.
|
Huge thanks for working through this big project with me. I think this is the last thing I would consider a blocker for the next pynacl release, so now it's just some housekeeping and getting a release out the door in the next few days/weeks. |
My pleasure---thanks for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now while CI runs.I started by adding annotations to
tests.utilslike I did the rest of the project, using the same strict config as before. Then I took a few modules and ran mypy on them, and dealt with any unexpected complaints reported by mypy. Then I suppressed the uninteresting errors in mypy config.Its complaints so far:
disallow_untyped_defsbeing unhappy that we haven't marked test function as-> None. There are some parameterised tests though, and I found it useful to add in annotations here to ensure the test body was doing something sensible.-> NoneAny. Not interesting; ignored in config.crypto_scalarmult_BYTESandSCALARBYTESwere untyped, see 10434eb. Easy to fix.crypto_boxwith a stringnonce. I'm a bit surprised this worked, to be honest. I guess the fact that the nonce was ascii-encodable (i.e. just nulls) might have helped?I didn't feel like annotating
check_type_errorthree times, so I pulled it out totests.utils. It's a bit naughty to do so in this PR (could spin it out?) and I felt a bit icky makingutilspull inpytest.