Finish off annotating nacl
#724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that all files are annotated, apply common settings globally so that the overrides only apply to `nacl.bindings`. In doing so, account for an `Any`-expression in `scrypt.py`. I must not have correctly configured mypy for `nacl.pwhash` in pyca#718: I think it should have been `nacl.pwhash.*` instead of `nacl.pwhash`.
reaperhulk
approved these changes
Dec 21, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of #692 and a little bit of effort to resolve merge conflicts.
Should be reviewable commit-by-commit.
I don't know if we'd consider this sufficient to close #660. It might be nice to run
mypyover the tests too.