Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support custom comments when formatting openssh private keys #8980

Open
gzm55 opened this issue May 29, 2023 · 5 comments · May be fixed by #9019
Open

add support custom comments when formatting openssh private keys #8980

gzm55 opened this issue May 29, 2023 · 5 comments · May be fixed by #9019
Milestone
Forty Third Release

Comments

@gzm55
Copy link

gzm55 commented May 29, 2023

The comment field is left empty when formatting as openssh key protocol. can we support to custom this comment field?
@alex
Copy link
Member

alex commented May 29, 2023

I think we'd accept a PR that added support to https://cryptography.io/en/latest/hazmat/primitives/asymmetric/serialization/#cryptography.hazmat.primitives.serialization.KeySerializationEncryptionBuilder

@gzm55
Copy link
Author

gzm55 commented Jun 2, 2023

when parsing from bytes, the comment is also lost.

@alex
Copy link
Member

alex commented Jun 2, 2023 via email

@gzm55 gzm55 linked a pull request Jun 3, 2023 that will close this issue
Open
@gzm55
Copy link
Author

gzm55 commented Jun 3, 2023 •
edited

I think we'd also be happy to take a PR exposing it.
…
On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao @.> wrote: when parsing from bytes, the comment is also lost. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>
-- All that is necessary for evil to succeed is for good people to do nothing.

@alex here is a simple pr to fix this issue

@gzm55
Copy link
Author

gzm55 commented Jun 7, 2023

any comments about this issue or the pr?

@alex alex added this to the Forty Second Release milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
Forty Third Release
Development

Successfully merging a pull request may close this issue.

pass or collect comments for ssh private keys gzm55/cryptography
2 participants
@alex @gzm55