Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix josepy tests by pinning poetry #7553

Merged
merged 2 commits into from Aug 31, 2022
Merged

attempt to fix josepy tests by pinning poetry #7553

merged 2 commits into from Aug 31, 2022

Conversation

alex
Copy link
Member

@alex alex commented Aug 31, 2022

No description provided.

@alex
Copy link
Member Author

alex commented Aug 31, 2022

@adferrand do you remember why we used -c with pip here? The latest poetry broke this and I'm trying to figure out how to fix it. In that process I've been told that perhaps -c was never supported python-poetry/poetry#6275 (comment)

@adferrand
Copy link
Contributor

Hello @alex !

We used the -c with pip to have reproducible builds.

Indeed poetry maintains a full dependency tree of the project with version locking, and can export this tree in the requirements.txt format.

So we can pass this file as a constraint file to pip and ensure that pip will install the exact version of every dependency needed as it has been defined by the upstream project.

@alex
Copy link
Member Author

alex commented Aug 31, 2022 via email

@alex
Copy link
Member Author

alex commented Aug 31, 2022

@adferrand it looks like not supporting -c is somewhat unintentional. Any ideas for how we can work around this to get stuff fixed? Pin poetry temporarily to give us time to think?

@alex alex changed the title attempt to fix josepy tests for new poetry release attempt to fix josepy tests by pinning poetry Aug 31, 2022
@reaperhulk reaperhulk merged commit edd1e69 into main Aug 31, 2022
@alex alex deleted the alex-patch-1 branch September 7, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants