Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing return type on default_backend makes the function untyped. #7130

Closed
Gaasmann opened this issue Apr 27, 2022 · 5 comments
Closed

Removing return type on default_backend makes the function untyped. #7130

Gaasmann opened this issue Apr 27, 2022 · 5 comments

Comments

@Gaasmann
Copy link
Contributor

Hello,

It seems that #6750 removed the return type for default_backend making the whole function untyped which makes mypy yell at us in our project for using an untyped function on a typed context.
You might want something like:

def default_backend() -> Any:

to play the role of WhoCares :-)

@reaperhulk
Copy link
Member

Happy to take a PR to do that if that's helpful!

@reaperhulk
Copy link
Member

We're planning to do a 37.0.1 today to fix another issue that cropped up with OpenSSL 3.0 so you can have this fix very quickly if you want 😄 (Please send two PRs: one to main and the other to 37.0.x)

@Gaasmann
Copy link
Contributor Author

Sounds good :-)
I just pushed #7131 and #7133, let me know if you see anything wrong.

@reaperhulk
Copy link
Member

Both look perfect, thanks for sending the backport PR!

@Gaasmann
Copy link
Contributor Author

Thank you! Closing the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants