fix changelog to remove inaccurate statement #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our PEM parser actually parses the first found PEM in a concatenated file, just like OpenSSL.
alex
reviewed
Sep 28, 2021
| @@ -16,8 +16,6 @@ Changelog | |||
| * **BACKWARDS INCOMPATIBLE:** Invalid ASN.1 found during :doc:`/x509/index` | |||
| parsing will raise an error on initial parse rather than when the invalid | |||
| field is accessed. | |||
| * **BACKWARDS INCOMPATIBLE:** Values passed to the :doc:`/x509/index` PEM | |||
There was a problem hiding this comment.
Just to be clear, does the parser accept leading extraneous data?
alex
approved these changes
Sep 29, 2021
0xaead
pushed a commit
to 0xaead/cryptography
that referenced
this pull request
Sep 29, 2021
Our PEM parser actually parses the first found PEM in a concatenated file, just like OpenSSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our PEM parser actually parses the first found PEM in a concatenated file, just like OpenSSL.