add CRL pyopenssl fallback #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Sep 28, 2021
alex
reviewed
Sep 28, 2021
Comment on lines
5
to
9
| pip install "pyopenssl[test]" | ||
| git clone https://github.com/pyca/pyopenssl | ||
| cd pyopenssl | ||
| VERSION=$(python -c "import OpenSSL;print(OpenSSL.__version__)") | ||
| git checkout "$VERSION" |
There was a problem hiding this comment.
Suggested change
| pip install "pyopenssl[test]" | |
| git clone https://github.com/pyca/pyopenssl | |
| cd pyopenssl | |
| VERSION=$(python -c "import OpenSSL;print(OpenSSL.__version__)") | |
| git checkout "$VERSION" | |
| VERSION=$(curl https://pypi.org/pypi/pyOpenSSL/json | jq -r .info.version) | |
| git clone https://github.com/pyca/pyopenssl | |
| cd pyopenssl | |
| git checkout "$VERSION" |
alex
approved these changes
Sep 28, 2021
0xaead
pushed a commit
to 0xaead/cryptography
that referenced
this pull request
Sep 29, 2021
* add tests to verify we haven't broken the current pyopenssl release * add CRL pyopenssl fallback * simplify CRL with helpers * more readable pyopenssl-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.