Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify an MSRV in setup.py #5789

Merged
merged 1 commit into from Feb 9, 2021
Merged

Specify an MSRV in setup.py #5789

merged 1 commit into from Feb 9, 2021

Conversation

alex
Copy link
Member

@alex alex commented Feb 8, 2021

No description provided.

@alex
Copy link
Member Author

alex commented Feb 8, 2021

Here's the output with this specified:

$ pip install -e .
[...]
    error: Rust 1.41.1 does not match extension requirement >=1.45.0
    
        =============================DEBUG ASSISTANCE=============================
        If you are seeing a compilation error please try the following steps to
        successfully install cryptography:
        1) Upgrade to the latest pip and try again. This will fix errors for most
           users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
        2) Read https://cryptography.io/en/latest/installation.html for specific
           instructions for your platform.
        3) Check our frequently asked questions for more information:
           https://cryptography.io/en/latest/faq.html
        4) Ensure you have a recent Rust toolchain installed:
           https://cryptography.io/en/latest/installation.html#rust
        5) If you are experiencing issues with Rust for *this release only* you may
           set the environment variable `CRYPTOGRAPHY_DONT_BUILD_RUST=1`.
        =============================DEBUG ASSISTANCE=============================

@reaperhulk reaperhulk merged commit f01dcd6 into master Feb 9, 2021
@reaperhulk reaperhulk deleted the alex-patch-1 branch February 9, 2021 00:09
@reaperhulk
Copy link
Member

Do we want to ship this in a 3.4.3?

@alex
Copy link
Member Author

alex commented Feb 9, 2021

I think so. I'll prep a backport PR.

alex added a commit to alex/cryptography that referenced this pull request Feb 9, 2021
reaperhulk pushed a commit that referenced this pull request Feb 9, 2021
* Specify an MSRV in setup.py (#5789)

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants