Interface: Make annotation check optional #5775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: pyca#5774 Signed-off-by: Christian Heimes <cheimes@redhat.com>
src/cryptography/utils.py
Outdated
Comment on lines
72
to
83
| def strip_annotation(signature): | ||
| return inspect.Signature( | ||
| [ | ||
| inspect.Parameter( | ||
| param.name, | ||
| param.kind, | ||
| default=param.default, | ||
| annotation=inspect.Parameter.empty, | ||
| ) | ||
| for param in signature.parameters.values() | ||
| ] | ||
| ) |
There was a problem hiding this comment.
What about replace methods?
for example,
return signature.replace(
parameters=[
param.replace(annotation=inspect.Parameter.empty)
for param in signature.parameters.values()
],
return_annotation=inspect.Signature.empty,
)
Co-authored-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Christian Heimes <cheimes@redhat.com>
|
Interesting, I hadn't realized anyone was using |
|
If we're breaking people on this we should definitely merge a fix. I'm fine with this approach. |
|
Note that this does change the default on whether it verifies sigs, I suppose that's fine? |
reaperhulk
approved these changes
Feb 8, 2021
|
Yeah I'm fine with that to be clear :) |
tiran
added a commit
to tiran/cryptography
that referenced
this pull request
Feb 8, 2021
* Interface: Make annotation check optional Fixes: pyca#5774 Signed-off-by: Christian Heimes <cheimes@redhat.com> * Use param.replace() Co-authored-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Christian Heimes <cheimes@redhat.com> Co-authored-by: Stanislav Levin <slev@altlinux.org>
reaperhulk
pushed a commit
that referenced
this pull request
Feb 8, 2021
* Interface: Make annotation check optional Fixes: #5774 Signed-off-by: Christian Heimes <cheimes@redhat.com> * Use param.replace() Co-authored-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Christian Heimes <cheimes@redhat.com> Co-authored-by: Stanislav Levin <slev@altlinux.org> Co-authored-by: Stanislav Levin <slev@altlinux.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5774
Signed-off-by: Christian Heimes cheimes@redhat.com