fixes #4531 -- support encoding SCTs in certificates #5594
Merged
+50
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
encode-scts
branch
2 times, most recently
from
a005cec to
4bb8465
Compare
|
This API only allows encoding of SCTs that were previously parsed by OpenSSL. We have no concrete type for SCT at this time so I understand why it's structured that way, but I think we need a way to create SCTs that doesn't involve just passing through pre-existing pointers. |
|
You're right that we need that API, but it's a whole separate thing -- we need an SCTBuilder or similar. I'd prefer to defer the implementation of that until we have Rust, since I'll implement it that way (and kill all of our usage of For now, I'd like to finish off the x.509 encode/decode parity. |
reaperhulk
approved these changes
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.