Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some words about separating ECDH and ECDSA #5423

Merged
merged 2 commits into from Aug 24, 2020
Merged

add some words about separating ECDH and ECDSA #5423

merged 2 commits into from Aug 24, 2020

Conversation

reaperhulk
Copy link
Member

fixes #4369

alex
alex reviewed Aug 24, 2020
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an external reference for this we can cite? (arguably fillipo's recent blog post which states that a key should know it's own algorithm)

@reaperhulk
Copy link
Member Author

Filippo's stuff would be okay. Thomas Pornin wrote a great explanation about this long ago on crypto stackexchange as well if we want to link that: https://crypto.stackexchange.com/a/3313

@alex
Copy link
Member

alex commented Aug 24, 2020

That's a good cite by me!

@alex alex merged commit b9d26d2 into pyca:master Aug 24, 2020
@reaperhulk reaperhulk deleted the docs-dc branch August 24, 2020 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API allows EC keys to be used for both signing and DH
2 participants
@reaperhulk @alex