Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate tests from wycheproof #3331

Closed
11 tasks done
alex opened this issue Dec 19, 2016 · 6 comments
Closed
11 tasks done

Integrate tests from wycheproof #3331

alex opened this issue Dec 19, 2016 · 6 comments
Labels
good first issue security-hardening testing
Milestone
Twenty third release

Comments

@alex
Copy link
Member

alex commented Dec 19, 2016 •
edited

https://github.com/google/wycheproof:

  • aes_cbc_pkcs5_test.json
  • aes_cmac_test.json
  • aes_gcm_test.json
  • chacha20_poly1305_test.json
  • dsa_test.json
  • ecdh*_test.json
  • ecdsa*_test.json
  • kw_test.json
  • kwp_test.json
  • rsa_signature*_test.json
  • x25519_test.json
@reaperhulk
Copy link
Member

They've published test vectors we can actually use now: https://github.com/google/wycheproof/tree/master/testvectors

@reaperhulk reaperhulk added this to the Twenty third release milestone Apr 4, 2018
@alex
Copy link
Member Author

alex commented Apr 5, 2018

For anyone interested in working on this, I think we should structure this so CI clones that repo and runs them -- do not copy them all in.

@reaperhulk
Copy link
Member

reaperhulk commented Apr 5, 2018 •
edited

@mithrandi and other distro packagers may have opinions about our tests containing network dependencies?

@alex
Copy link
Member Author

alex commented Apr 5, 2018

My proposal is that the CI would do the clone, outside the scope of tox/pytest, and then give the location to pytest somehow. Distros could then reproduce this logic.

@mithrandi
Copy link
Contributor

Debian packages are built without network access, so there would need to be a way to disable the downloading. @alex's suggestion seems reasonable since I could ship the vectors in the source package.

alex added a commit to alex/cryptography that referenced this issue Jul 5, 2018
@alex
Refs pyca#3331 -- added initial wycheproof integration, starting with…
0ad022b 
… x25519 tests
alex added a commit to alex/cryptography that referenced this issue Jul 5, 2018
@alex
Refs pyca#3331 -- added initial wycheproof integration, starting with…
c4e53af 
… x25519 tests
alex added a commit to alex/cryptography that referenced this issue Jul 6, 2018
@alex
Refs pyca#3331 -- added initial wycheproof integration, starting with…
e71953d 
… x25519 tests
@reaperhulk
Copy link
Member

When we add the KWP vectors we should test to see if it would catch the 0 mod 8 bug we had.

alex added a commit to alex/cryptography that referenced this issue Jul 10, 2018
@alex
Refs pyca#3331 -- added initial wycheproof integration, starting with…
65ec854 
… x25519 tests
alex added a commit to alex/cryptography that referenced this issue Jul 10, 2018
@alex
Refs pyca#3331 -- added initial wycheproof integration, starting with…
91af9ba 
… x25519 tests
reaperhulk pushed a commit that referenced this issue Jul 16, 2018
@alex @reaperhulk
Refs #3331 -- added initial wycheproof integration, starting with x25…
2e85a92 
…519, rsa, and keywrap (#4310)

* Refs #3331 -- added initial wycheproof integration, starting with x25519 tests
alex added a commit to alex/cryptography that referenced this issue Jul 17, 2018
@alex
Refs pyca#3331 -- integrated wycheproof ECDSA tests
6bf3e2d
This was referenced Jul 17, 2018
Merged
Merged
Merged
Merged
reaperhulk pushed a commit that referenced this issue Jul 17, 2018
@alex @reaperhulk
Refs #3331 -- integrated wycheproof ECDSA tests (#4341)
c574e75 
* Refs #3331 -- integrated wycheproof ECDSA tests

* Also handle these key loading errors

* review

* empty commit to trigger jenkins
@reaperhulk reaperhulk mentioned this issue Jul 17, 2018
Merged
alex added a commit to alex/cryptography that referenced this issue Jul 17, 2018
@alex
Refs pyca#3331 -- integrated wycheproof ECDH tests
0095a3b
reaperhulk pushed a commit that referenced this issue Jul 18, 2018
@alex @reaperhulk
Refs #3331 -- integrated wycheproof ECDH tests (#4354)
feb1345 
* Refs #3331 -- integrated wycheproof ECDH tests

* flake8 + missing assert

* Handle this error case

* skip on unsupported

* shouldn't need to try here any more
@alex alex closed this as completed Jul 18, 2018
amauryfa pushed a commit to amauryfa/cryptography that referenced this issue Jul 22, 2018
@alex
Refs pyca#3331 -- added initial wycheproof integration, starting with…
c3f2a68 
… x25519, rsa, and keywrap (pyca#4310)

* Refs pyca#3331 -- added initial wycheproof integration, starting with x25519 tests
amauryfa pushed a commit to amauryfa/cryptography that referenced this issue Jul 22, 2018
@alex
Refs pyca#3331 -- integrated wycheproof ECDSA tests (pyca#4341)
ee711cc 
* Refs pyca#3331 -- integrated wycheproof ECDSA tests

* Also handle these key loading errors

* review

* empty commit to trigger jenkins
amauryfa pushed a commit to amauryfa/cryptography that referenced this issue Jul 22, 2018
@alex
Refs pyca#3331 -- integrated wycheproof ECDH tests (pyca#4354)
6d0b22c 
* Refs pyca#3331 -- integrated wycheproof ECDH tests

* flake8 + missing assert

* Handle this error case

* skip on unsupported

* shouldn't need to try here any more
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue security-hardening testing
Milestone
Twenty third release
Development

No branches or pull requests
3 participants
@alex @reaperhulk @mithrandi