Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare for 2.10.3 #4437

Merged
merged 3 commits into from Jan 3, 2023
Merged

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jan 2, 2023

Will cherry-pick onto v2.10.

@henryiii
Copy link
Collaborator Author

henryiii commented Jan 2, 2023

Clang 10 C++20 seems busted, but Clang 11 C++20 is fine. Should we do something, or just declare Clang 11+ is required for C++20 mode?

@rwgk
Copy link
Collaborator

rwgk commented Jan 2, 2023

just declare Clang 11+ is required for C++20 mode?

Sounds best to me.

In the unlikely (I guess) event that someone cares enough later we can do something then.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit b2d7ad7 into pybind:master Jan 3, 2023
@henryiii henryiii deleted the henryiii/chore/2.10.3 branch January 3, 2023 16:34
henryiii added a commit that referenced this pull request Jan 3, 2023
* docs: update changelog for v2.10.3

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

* chore: bump versions for 2.10.3

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

* chore: fix make changelog script with entry is empty

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants