Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update clang-tidy to 15 #4387

Merged
merged 10 commits into from Dec 27, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • Update clang-tidy docker container to clang 15 and the new way of installing / generating Silekh docker containers.

Suggested changelog entry:

* Update clang-tidy to 15 in CI

@Skylion007 Skylion007 marked this pull request as ready for review December 6, 2022 15:51
@Skylion007 Skylion007 requested a review from rwgk December 6, 2022 15:51
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one clang-tidy failure:

/__w/pybind11/pybind11/include/pybind11/stl.h:319:34: error: unchecked access to optional value [bugprone-unchecked-optional-access,-warnings-as-errors]
        return value_conv::cast(*std::forward<T>(src), policy, parent);
                                 ^

Please feel free to merge when that's resolved, with or without the suggested change.

include/pybind11/stl_bind.h Outdated Show resolved Hide resolved
@Skylion007 Skylion007 merged commit 7f23e9f into pybind:master Dec 27, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Dec 27, 2022
@Skylion007 Skylion007 deleted the update-clang-tidy-to-15 branch December 28, 2022 15:25
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jan 3, 2023
rwgk added a commit to rwgk/pybind11 that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants