From 9d6a79c090832afe9b3140fe9ea92142f7f2329c Mon Sep 17 00:00:00 2001
From: cyy <cyyever@outlook.com>
Date: Tue, 3 Jan 2023 23:20:39 +0800
Subject: [PATCH] fix: issuses detected by static analyzer (#4440)

* fix incorrect variable check

* remove duplicated check

* remove unneeded const cast
---
 include/pybind11/attr.h         | 2 +-
 include/pybind11/eigen/tensor.h | 2 +-
 include/pybind11/pytypes.h      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/pybind11/attr.h b/include/pybind11/attr.h
index db7cd8efff..b5e3b7b22c 100644
--- a/include/pybind11/attr.h
+++ b/include/pybind11/attr.h
@@ -399,7 +399,7 @@ struct process_attribute<doc> : process_attribute_default<doc> {
 template <>
 struct process_attribute<const char *> : process_attribute_default<const char *> {
     static void init(const char *d, function_record *r) { r->doc = const_cast<char *>(d); }
-    static void init(const char *d, type_record *r) { r->doc = const_cast<char *>(d); }
+    static void init(const char *d, type_record *r) { r->doc = d; }
 };
 template <>
 struct process_attribute<char *> : process_attribute<const char *> {};
diff --git a/include/pybind11/eigen/tensor.h b/include/pybind11/eigen/tensor.h
index 568c641a2d..0877da8953 100644
--- a/include/pybind11/eigen/tensor.h
+++ b/include/pybind11/eigen/tensor.h
@@ -176,7 +176,7 @@ struct type_caster<Type, typename eigen_tensor_helper<Type>::ValidType> {
                 return false;
             }
 
-            if (!convert && !temp.dtype().is(dtype::of<typename Type::Scalar>())) {
+            if (!temp.dtype().is(dtype::of<typename Type::Scalar>())) {
                 return false;
             }
         }
diff --git a/include/pybind11/pytypes.h b/include/pybind11/pytypes.h
index a2824a0e01..f11ed5da78 100644
--- a/include/pybind11/pytypes.h
+++ b/include/pybind11/pytypes.h
@@ -501,7 +501,7 @@ struct error_fetch_and_normalize {
                             "active exception.");
         }
         const char *exc_type_name_norm = detail::obj_class_name(m_type.ptr());
-        if (exc_type_name_orig == nullptr) {
+        if (exc_type_name_norm == nullptr) {
             pybind11_fail("Internal error: " + std::string(called)
                           + " failed to obtain the name "
                             "of the normalized active exception type.");