-
Notifications
You must be signed in to change notification settings - Fork 132
Forcing SMP in student versions. #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+102
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
- Coverage 81.88% 81.74% -0.14%
==========================================
Files 43 43
Lines 6778 6778
==========================================
- Hits 5550 5541 -9
- Misses 1228 1237 +9 |
germa89
commented
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
germa89
added a commit
that referenced
this pull request
Oct 11, 2022
* Forcing SMP in student versions. * Fixing unit tests. * Adding info to the docstring about the change. * Document the change in the docs and also notice the student version portal. * Fixing style.
germa89
added a commit
that referenced
this pull request
Oct 11, 2022
* Forcing SMP in student versions. * Fixing unit tests. * Adding info to the docstring about the change. * Document the change in the docs and also notice the student version portal. * Fixing style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1485 by enforcing
smp
in student versions.