Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML proofer not ignoring directories #28

Closed
lwasser opened this issue Oct 11, 2022 · 1 comment
Closed

HTML proofer not ignoring directories #28

lwasser opened this issue Oct 11, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@lwasser
Copy link
Member

lwasser commented Oct 11, 2022

HTML proofer is not ignoring directories that it should be. I've played with the ruby regex using Rubular and it should be correct. but it's obviously not working. it works on the first URL but not the second.

opened an issue about this HERE in hopes someone can point me to what i'm doing incorrectly in the ruby regex syntax.

uses: chabad360/htmlproofer@master
        with:
          directory: '_build/html'
          arguments: |
           --ignore-files "/.+\/_static/, /.+\/reference\/meeting-notes.+/"
       
      - name: Push to gh-pages branch for publication from main
        if: github.ref == 'refs/heads/main'
        uses: peaceiris/actions-gh-pages@v3
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          publish_dir: ./_build/html

THIS so post was also helpful - https://stackoverflow.com/questions/29678646/can%C2%B4t-get-htmlproof-to-accept-an-ignore-pattern

i'm struggling to install it locally because it wants ruby 3.x and i have 2.x running. worried it will break my website build to install 3.x - don't have the energy to fix the website right now. min mistakes wants 2.x it seems.

@lwasser lwasser added the bug Something isn't working label Oct 11, 2022
@lwasser
Copy link
Member Author

lwasser commented Oct 12, 2022

My goodness the issue was a space after the comma! who would have thought

i missed that

--ignore-files "/.+\/_static/, /.+\/reference\/meeting-notes.+/"

vs
--ignore-files "/.+\/_static/,/.+\/reference\/meeting-notes.+/"

made the difference. running now so closing this! phew!

@lwasser lwasser closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant